40 implement a secure key storage functionality for the pop server #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emporary buffer used for reading the keystore file.
…, secure key storage, and robust file operations.
Tekum-Emmanuella
requested review from
Hermann-Core and
Christiantyemele
and removed request for
Hermann-Core
Christiantyemele
requested changes
Sep 25, 2024
crates/keystore/src/lib.rs
Outdated
| Ok(()) | ||
| } | ||
|
|
||
| fn decrypt(self, secret: KeyStore) -> Result<Vec<u8>, std::io::Error> { |
There was a problem hiding this comment.
This functions you created are not used, where do you call them ?
|
|
||
| Ok(decrypted_key) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please also provide tests for your functions
Christiantyemele
requested changes
Sep 25, 2024
Hermann-Core
requested changes
Sep 26, 2024
Comment on lines
+1
to
+23
| use thiserror::Error; | ||
|
|
||
| #[derive(Debug, Error)] | ||
| pub enum KeystoreError { | ||
| #[error("File error: {0}")] | ||
| FileError(std::io::Error), | ||
| #[error("JwkConversionError")] | ||
| JwkConversionError, | ||
| #[error("KeyPairGenerationError")] | ||
| KeyPairGenerationError, | ||
| #[error("non compliant")] | ||
| NonCompliant, | ||
| #[error("not found")] | ||
| NotFound, | ||
| #[error("parse error")] | ||
| ParseError(serde_json::Error), | ||
| #[error("serde error")] | ||
| SerdeError(serde_json::Error), | ||
| #[error("Encryption error: {0}")] | ||
| EncryptionError(chacha20poly1305::Error), | ||
| #[error("Decryption error: {0}")] | ||
| DecryptionError(chacha20poly1305::Error), | ||
| } |
There was a problem hiding this comment.
Your errors need to be more descriptive:
Suggested change
| use thiserror::Error; | |
| #[derive(Debug, Error)] | |
| pub enum KeystoreError { | |
| #[error("File error: {0}")] | |
| FileError(std::io::Error), | |
| #[error("JwkConversionError")] | |
| JwkConversionError, | |
| #[error("KeyPairGenerationError")] | |
| KeyPairGenerationError, | |
| #[error("non compliant")] | |
| NonCompliant, | |
| #[error("not found")] | |
| NotFound, | |
| #[error("parse error")] | |
| ParseError(serde_json::Error), | |
| #[error("serde error")] | |
| SerdeError(serde_json::Error), | |
| #[error("Encryption error: {0}")] | |
| EncryptionError(chacha20poly1305::Error), | |
| #[error("Decryption error: {0}")] | |
| DecryptionError(chacha20poly1305::Error), | |
| } | |
| use thiserror::Error; | |
| #[derive(Debug, Error)] | |
| pub enum KeystoreError { | |
| #[error("File operation failed: {0}")] | |
| FileError(#[from] std::io::Error), | |
| #[error("JWK conversion failed")] | |
| JwkConversionError, | |
| #[error("Key pair generation failed")] | |
| KeyPairGenerationError, | |
| #[error("Non-compliant data")] | |
| NonCompliant, | |
| #[error("Item not found")] | |
| NotFound, | |
| #[error("Failed to parse JSON data: {0}")] | |
| ParseError(#[from] serde_json::Error), | |
| #[error("Serialization error: {0}")] | |
| SerializationError(#[from] serde_json::Error), | |
| #[error("Deserialization error: {0}")] | |
| DeserializationError(#[from] serde_json::Error), | |
| #[error("Encryption failed: {0}")] | |
| EncryptionError(#[from] chacha20poly1305::Error), | |
| #[error("Decryption failed: {0}")] | |
| DecryptionError(#[from] chacha20poly1305::Error), | |
| } |
Comment on lines
+30
to
+33
| struct FileSystemKeystore { | ||
| key: SecretString, // Store key securely using secrecy crate | ||
| nonce: Vec<u8>, | ||
| } |
There was a problem hiding this comment.
What is the purpose of this struct? It is not constructed anywhere.
crates/keystore/src/lib.rs
Outdated
|
|
||
| let encrypted_key = cipher | ||
| .encrypt(GenericArray::from_slice(&self.nonce), buffer.as_slice()) | ||
| .map_err(|err| err).unwrap(); |
There was a problem hiding this comment.
Why do you map the error when not going to propagate it?
| debug!("Encryption successful for keystore file: {}", path); | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
I don't really understand what you are trying to do here. Your encrypt function is not used anywhere, I suppose that you created it to encrypt the keys before storing them? If that's the purpose, then how are you going to decrypt them later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.